[DataViews] Use client-side authc.getCurrentUser from core.security #186856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
Team:Core
tsullivan
force-pushed
the
security-in-core/data-views-plugin-public
branch
2 times, most recently
from
26db7aa to
548fcbe
Compare
tsullivan
changed the title
10 tasks
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
pgayvallet
approved these changes
Jun 25, 2024
lukasolson
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Added a small PR that simplifies things a tad more here: tsullivan#12
tsullivan
force-pushed
the
security-in-core/data-views-plugin-public
branch
from
9297aa1 to
c7346e6
Compare
tsullivan
force-pushed
the
security-in-core/data-views-plugin-public
branch
from
c7346e6 to
c73e220
Compare
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
lukasolson
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #186574
Background: This PR serves as an example of a plugin migrating away from depending on the Security plugin, which is a high priority effort for the last release before 9.0. The Data Views plugin uses the
authc.getCurrentUsermethod as a means to use the user's profile_uid for creating a user-hash which is sent as a field in the headers of a particular request.What makes this example interesting: Data Views was not able to have a direct dependency on the Security plugin due to issues with a circular dependency. As a workaround, it used the
coreSetup.plugins.onStartPromise to use Security services in a non-contractual way. The change in this PR does away with the workaround and allows Data Views to consume the Security service in a more typical way.Checklist
Delete any items that are not applicable to this PR.